fix: capture customLabelProp if set #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +84 B (+0.08%) Total Size: 106 kB
ℹ️ View Unchanged
|
marandaneto
commented
Nov 4, 2024
| @@ -91,7 +93,7 @@ export const PostHogProvider = ({ | |||
|
|
|||
| return ( | |||
| <View | |||
| ph-label="PostHogProvider" | |||
| {...{ [phLabelProp]: 'PostHogProvider' }} // Dynamically setting customLabelProp (default: ph-label) | |||
There was a problem hiding this comment.
that is chatgpt code :D
4 tasks
ioannisj
reviewed
Nov 5, 2024
| const elAttrLabelKey = `attr__${customLabelProp}` | ||
| let lastLabel: string | undefined = undefined | ||
|
|
||
| for (let i = elements.length - 1; i >= 0; i--) { | ||
| const element = elements[i] | ||
| if (element[elAttrLabelKey]) { | ||
| // this element had a ph-label set, promote it to the lastLabel | ||
| // this element had a customLabelProp (default: ph-label) set, promote it to the lastLabel |
There was a problem hiding this comment.
Can't we just iterate over normally here with early exit instead of reverse?
There was a problem hiding this comment.
the reason why it is reversed is in the comment above.
I'd not change what's working already as well, the change is about using the wrong label name only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #301
Changes
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes