Allow easier injection of customized MySqlRelationalConnection implementations from user code
#1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or user code) by splitting the creation method for admin/master connections.
lauxjpn
added
type-enhancement
backport-candidate
lauxjpn
changed the title
MySqlRelationalConnection from user codeMySqlRelationalConnection implementation from user code
lauxjpn
changed the title
MySqlRelationalConnection implementation from user codeMySqlRelationalConnection implementations from user code
lauxjpn
added a commit
to lauxjpn/Pomelo.EntityFrameworkCore.MySql
that referenced
this pull request
Mar 15, 2024
…or user code) by splitting the creation method for admin/master connections. (PomeloFoundation#1863) (cherry picked from commit 1ccd763)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users want to replace the default
MySqlRelationalConnectioninstance with with a customized derived one of their own (e.g. by using.ReplaceService<IMySqlRelationalConnection, MyCustomMySqlRelationalConnection>()), they had difficulties returning their customized implementation from theCreateMasterConnection()method.This PR enables users to override
CreateMasterConnectionCore()instead, to allow them to create and return their custom instance in a way that is as simple as possible.