Merge pull request #25 from PagerDuty/easierErrorCodes

Only attempt to .json() if success response.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pagerduty/pdjs",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "A new simple JavaScript wrapper for the PagerDuty API",
   "main": "build/src/index.js",
   "types": "build/src/index.d.ts",

src/api.test.ts

@@ -166,7 +166,7 @@ test('API explodes list based parameters properly', async done => {
   });
 
   expect(resp.url).toEqual(
-    `https://api.pagerduty.com/incidents?additional_fields%5B%5D=one&additional_fields%5B%5D=two&additional_fields%5B%5D=three`
+    'https://api.pagerduty.com/incidents?additional_fields%5B%5D=one&additional_fields%5B%5D=two&additional_fields%5B%5D=three'
   );
   done();
 });

src/api.ts

@@ -100,16 +100,19 @@ function apiRequest(url: string, options: RequestOptions): APIPromise {
   return request(url, options).then(
     (response: Response): APIPromise => {
       const apiResponse = response as APIResponse;
+      apiResponse.response = response;
       const resource = resourceKey(url);
-      return response.json().then(
-        (data): APIResponse => {
-          apiResponse.next = nextFunc(url, options, data);
-          apiResponse.data = data;
-          apiResponse.resource = resource ? data[resource] : null;
-          apiResponse.response = response;
-          return apiResponse;
-        }
-      );
+      return response
+        .json()
+        .then(
+          (data): APIResponse => {
+            apiResponse.next = nextFunc(url, options, data);
+            apiResponse.data = data;
+            apiResponse.resource = resource ? data[resource] : null;
+            return apiResponse;
+          }
+        )
+        .catch(() => Promise.resolve(apiResponse));
     }
   );
 }