Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial part in order to solve BetterThanTomorrow/calva#807
I have merged an "as-is" approach the indentation changes on top of the latest 0.7.0 version.
While doing this I can see there is a lot of history discussed around this topic: weavejester#77
The tests have purposely been left as failing to keep them open as discussion points. Some will fail as the indentation is applied.
However, see others below:
Do we want to remove the comma in this case?
We should probably remove the comma in this case, or keep it like the next case?
Another comma case:
Then I would like to add the case from BetterThanTomorrow/calva#807 which is the alignment when there is type hinting: