Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components,-protocol-designer,-step-generation): full absorbance reader step form UI #17306

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Jan 17, 2025

TODO:

  • add tests (followup PR?)

Overview

This PR completes the UI for absorbance reader step form, specifically creating the initialization editor component. It also adds form errors for all implicated fields throughout the form.

Note that because all wavelengths are actually produced by the same form field, logic for handling each individual wavelength error is handled within the component rather than our existing infrastructure for form/fieldLevel errors.

Closes AUTH-1267, Closes AUTH-1315

Test Plan and Hands on Testing

  • walk through creating absorbance plate reader steps (initialize single/multi, open lid, move labware, read), and verify that error handling and UI functionality works as expected
  • export and inspect commands and verify that commands and params are correct

Changelog

  • add component for handling initialization editing
  • add all translations for step form
  • fix defaults and form types

Review requests

see test plan

Risk assessment

low. should not implicate any other parts of PD not related to the absorbance reader step form

… reader step form UI

This PR completes the UI for absorbance reader step form, specifically creating the initialization editor component. It also adds form errors for all implicated fields throughout the form.

Closes AUTH-1267, Closes AUTH-1315
@ncdiehl11 ncdiehl11 self-assigned this Jan 17, 2025
@ncdiehl11 ncdiehl11 requested review from koji and jerader January 17, 2025 22:07
@ncdiehl11 ncdiehl11 marked this pull request as ready for review January 17, 2025 22:08
@ncdiehl11 ncdiehl11 requested review from a team as code owners January 17, 2025 22:08
@ncdiehl11 ncdiehl11 removed request for a team January 17, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant