feat(hardware, shared-data, api): Support LV 96 channel #16747
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Nov 8, 2024
| @@ -1774,7 +1774,8 @@ | |||
| "p1000_single_gen2", | |||
| "p1000_single_flex", | |||
| "p1000_multi_flex", | |||
| "p1000_96" | |||
| "p1000_96", | |||
There was a problem hiding this comment.
this needs to be in the shared-data PR I think
| @@ -587,7 +588,11 @@ export const WASTE_CHUTE_STAGING_AREA_FIXTURES: CutoutFixtureId[] = [ | |||
| STAGING_AREA_SLOT_WITH_WASTE_CHUTE_RIGHT_ADAPTER_NO_COVER_FIXTURE, | |||
| ] | |||
|
|
|||
| export const LOW_VOLUME_PIPETTES = ['p50_single_flex', 'p50_multi_flex'] | |||
| export const LOW_VOLUME_PIPETTES = [ | |||
There was a problem hiding this comment.
this variable is used to cause PD to generate configureForVolume commands before each aspirate - the "low volume" part is "has a lowVolume liquid configuration". Will the LV96 have one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add all of the string constants for the pipette type, and then update some of the loading/checking of pipette types that were explicitly checking only the 1000ul version of the 96.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment