feat(api): add labware-scope liquid loading api #16745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had the ability to load liquids on individual Wells, but this creates an engine command per well - which can be very onerous for large labware - and requires loops and such to load liquids. The common case for loading liquids is that everything is the same, and the second common case is that you care about a labware as a whole at a time (e.g. because you're reading from a platemap). We can support these uses better by having Labware.load_liquid (for many wells with the same amount of liquid), Labware.load_liquid_by_well (more complex, for more complex use cases) and Labware.load_empty, all taking arguments of the type that you can derive from other PAPI methods or domain-specific reasoning. Also, remove well.load_empty because it wasn't shipped yet and is now duplicative. Closes EXEC-825
sfoster1
requested review from
ecormany,
SyntaxColoring,
TamarZanzouri,
vegano1 and
CaseyBatten
|
Thanks for the docstrings. Added a followup ticket RTC-626 to take some of that content and build it into other docs pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the ability to load liquids on individual Wells, but this creates an engine command per well - which can be very onerous for large labware
We can support these uses better by having Labware.load_liquid (for many wells with the same amount of liquid), Labware.load_liquid_by_well (more complex, for more complex use cases) and Labware.load_empty, all taking arguments of the type that you can derive from other PAPI methods or domain-specific reasoning.
Also, remove well.load_empty because it wasn't shipped yet and is now duplicative.
Closes EXEC-825