Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix modal position #16733

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Nov 7, 2024

Overview

fix modal position for modals in PD (add marginLeft="0")

part of RQA-3383

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

fix modal position for modals in PD

part of RQA-3383
@koji koji marked this pull request as ready for review November 7, 2024 22:24
@koji koji requested a review from a team as a code owner November 7, 2024 22:24
@koji koji added the authorship label Nov 7, 2024
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm i don't love this, seems like eventually we need the Modal component to be able to tell between the 2 better. But this is an okay fix for now. thanks for fixing it!

@koji koji merged commit 041c11a into edge Nov 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants