feat(protocol-designer): update TC profile modal to align with the latest design #16731
+82
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test design update TC profile modal to align with the latest design close AUTH927
koji
commented
Nov 7, 2024
Comment on lines
+215
to
+234
| <Btn | ||
| whiteSpace={NO_WRAP} | ||
| textDecoration={TYPOGRAPHY.textDecorationUnderline} | ||
| onClick={() => { | ||
| setShowEditCurrentStep(true) | ||
| setIsInEdit(true) | ||
| }} | ||
| padding={SPACING.spacing4} | ||
| css={[ | ||
| BUTTON_LINK_STYLE, | ||
| css` | ||
| visibility: ${hover ? 'visible' : 'hidden'}; | ||
| opacity: ${hover ? 1 : 0}; | ||
| `, | ||
| ]} | ||
| > | ||
| <StyledText desktopStyle="bodyDefaultRegular"> | ||
| {i18n.format(t('edit'), 'capitalize')} | ||
| </StyledText> | ||
| </Btn> |
There was a problem hiding this comment.
using this way because adding padding to Btn will causes the layout shift issue.
I think reserved space for edit button is the easiest way. But I'm open to any better suggestions.
https://opentrons.slack.com/archives/C07E9T2NAQK/p1731007655280299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update TC profile modal to align with the latest design
close AUTH-927
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low