fix(protocol-designer): liquid preservation in zoomed in slot and x button

[jerader]

closes AUTH-1016, partially addresses RQA-3526

Overview

Oof this was a bit confusing but i think the liquid edit experience is fixed now when you edit a labware with liquids in it already.

Test Plan and Hands on Testing

First check that the X button is added to deck setup tools and works as expected

Then, zoom into a slot with liquids and click done without doing anything, the liquids should be preserved until you press done
Next, zoom into a slot with liquids and click on different labware, liquids should not be preserved across labware but SHOULD be preserved if you go back to the original labware. once you press done, the liquids are not preserved.

Check that this pattern works for labware on the deck, labware on an adapter, labware on a module, and labware on an adapter on a module

here is a test protocol:
1.0 testing.json

Changelog

• add x button to DeckSetupTools
• keep track of the starting selected item state so done only updates if there are changes
• refine logic for showing liquids on the labware in selectedHoweverLabware and split up component
• fix tests

Risk assessment

low

[jerader]

for some reason selectedSlotInfoRef wasn't correctly showing the initial state that selectedSlotInfo was showing so i had to add a useEffect to initialize it. I did some debugging and tried memoizing but that didn't work. Open to other ideas anyone has!

[koji]

maybe creating a function or

use const selectedSlotInfo = useSelector(selectors.getZoomedInSlotInfo) in DeckSetupContainer and pass selectedSlotInfo as a prop?

function useUpdatedRef<T>(value: T): MutableRefObject<T> {
    const ref = useRef(value)
    if (!isEqual(ref.current, value)) {
      ref.current = value
    }
    return ref
  }

[jerader]

omg that is a great idea, thank you!!!

[koji]

could not add a module and a labware to a slot and could not change a labware

test.mov

[jerader]

could not add a module and a labware to a slot and could not change a labware

test.mov

@koji oh wow, thanks for catching this! let me see if i can fix it before EOD

[jerader]

this seems to fix the bug. I think we need to refactor DeckSetupContainer, DeckSetupTools and DeckSetupDetails and how it gets and keeps track of the initial slot information. If you log anything in DeckSetupTools, you'll see it get re-rendered a bunch of times. Part of the re-rendering is due to the animation of zooming in. I guess what we have now is fine but definitely should be revisited and refactored post-release.

[koji]

lgtm