-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(robot_context): Add pipette helper functions to convert volume and position type #16682
Open
Laura-Danielle
wants to merge
62
commits into
edge
Choose a base branch
from
PLAT-453-PLAT-454-add-pipette-support-functions
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(robot_context): Add pipette helper functions to convert volume and position type #16682
Laura-Danielle
wants to merge
62
commits into
edge
from
PLAT-453-PLAT-454-add-pipette-support-functions
+7,466
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as helper methods
sfoster1
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what we're getting at, but I think we should do it a little differently. Specifically,
- We should not do this in the core. Doing this in the core makes it impossible to execute commands of this type outside python protocols; it also pushes logic, or in this case duplicates logic, pretty high up. Instead, what about making the engine commands that you would give the positions to take either volume or distance, and convert internally? And for the conversions, let's make the actual math and the actual detail lookup part of an engine state handler that the api drills into, so that the logic and the lookup doesn't live in the core files.
- let's not duplicate things like ul per mm. They're data agnostic so let's make them shared utility functions.
- if we're going to push stuff into the engine, let's push it all the way. we definitely should not have new things in
core/engine
that reach into the hardware controller directly - let's get that stuff from the engine.
Laura-Danielle
force-pushed
the
PLAT-351-move-axes-to-position
branch
from
November 7, 2024 21:52
d1ccdab
to
5d0e3c8
Compare
Laura-Danielle
force-pushed
the
PLAT-351-move-axes-to-position
branch
4 times, most recently
from
November 8, 2024 22:00
5271362
to
1fb5978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For the
robot_context
, it is important to be able to convert volume and named positions to an AxisMap so that it can be passed in to therobot_context
move functions.Test Plan and Hands on Testing
Tested on a flex to verify that the pipette moves to the correct locations.
Changelog
Review requests
Are we OK with some of the conversions living in the robot core?
Risk assessment
Low, unreleased API.