Update remappings.txt for upgradeable contracts and set up submodule #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
frangio
commented
Sep 29, 2023
.github/workflows/upgradeable.yml
Outdated
| @@ -5,6 +5,7 @@ on: | |||
| branches: | |||
| - master | |||
| - release-v* | |||
| - partial-submodules | |||
There was a problem hiding this comment.
Should be removed before merging.
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Amxx
temporarily deployed
to
push-upgradeable
GitHub Actions
Inactive
Amxx
reviewed
Sep 29, 2023
Amxx
previously approved these changes
Sep 29, 2023
ernestognw
reviewed
Sep 29, 2023
| - name: Install Foundry | ||
| uses: foundry-rs/foundry-toolchain@v1 | ||
| with: | ||
| version: nightly |
There was a problem hiding this comment.
I don't know, I copied it from the foundry tests job.
ernestognw
reviewed
Sep 29, 2023
Co-authored-by: Ernesto García <[email protected]>
frangio
temporarily deployed
to
push-upgradeable
GitHub Actions
Inactive
frangio
temporarily deployed
to
push-upgradeable
GitHub Actions
Inactive
frangio
temporarily deployed
to
push-upgradeable
GitHub Actions
Inactive
frangio
temporarily deployed
to
push-upgradeable
GitHub Actions
Inactive
frangio
temporarily deployed
to
push-upgradeable
GitHub Actions
Inactive
Co-authored-by: Ernesto García <[email protected]>
frangio
added a commit
that referenced
this pull request
Oct 2, 2023
…4639) Co-authored-by: Hadrien Croubois <[email protected]> Co-authored-by: Ernesto García <[email protected]> (cherry picked from commit abba0d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4628, this PR sets up the vanilla contracts in a submodule and updates remappings.txt accordingly.
In order for Hardhat to respect remappings.txt, we need the
hardhat-foundryplugin to be installed, which needs theforgeexecutable in scope.Find the result for this PR here: https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/tree/partial-submodules