LoongArch64: Fixed lapack test for LA264 #5124
Open
+402
−2,158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed register zeroing operation Signed-off-by: Hao Chen <[email protected]> Signed-off-by: gxw <[email protected]>
Fixed incorrect register usage in instructions Signed-off-by: gxw <[email protected]>
Fixed index retrieval issue when there are identical maximum absolute values Signed-off-by: Hao Chen <[email protected]> Signed-off-by: gxw <[email protected]>
Fixed incorrect store operation Signed-off-by: gxw <[email protected]>
Do not check whether the input parameters c and s are zero, as this may cause errors with special values (same as scal). Although OpenBLAS's own test suite doesn't catch this, it will cause LAPACK test cases to fail.
Fixed the error when the stride is zero
When the data type is single-precision real or single-precision complex, converting it to double precision does not prevent overflow (as exposed in LAPACK tests). The only solution is to follow C's approach: find the maximum value in the array and divide each element by that maximum to avoid this issue
XiWeiGu
force-pushed
the
LoongArch64-LA264-lapack-fixed
branch
from
68f9c81 to
2c4a5cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the error when running make lapack-test with TARGET=LA264