Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication in kernel definitions #4390

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

Mousius
Copy link
Contributor

@Mousius Mousius commented Dec 23, 2023

These files are exactly the same, so I believe we can reduce these files down. Other files require a slightly more complex unpicking.

These files are exactly the same, so I believe we can reduce these files
down. Other files require a slightly more complex unpicking.
@Mousius
Copy link
Contributor Author

Mousius commented Dec 23, 2023

I noticed you did a lot of this already @martin-frbg , thanks for picking that up in my absence 😸 It's getting a lot easier to understand and maintain.

@martin-frbg
Copy link
Collaborator

Thanks. Much of the duplication is from earlier days when it was not quite clear if cpu-specific versions of all kernels would be necessary, rather than just suitable parameters. I had only done a minimal cleanup as some KERNEL files were no longer up to date with your recent SVE work.

@martin-frbg martin-frbg added this to the 0.3.26 milestone Dec 24, 2023
@martin-frbg martin-frbg merged commit 63a8393 into OpenMathLib:develop Dec 24, 2023
49 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants