macOS PowerPC: fix CMake build #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barracuda156
force-pushed
the
unbreak_powerpc
branch
from
764b749 to
981e315
Compare
barracuda156
changed the title
12 tasks
|
@martin-frbg Thank you! |
|
Well, thank you for doing all the debugging on a platform I cannot test. |
|
Wonder if that CMake issue with spaces is by design or unintentional from its side. |
|
I haven't looked in detail yet, but it is probably a bit of sloppy coding (by me) in utils.cmake - but there must be a CMake version component to it as the problem was not reproducible on IBM POWER 8/9 running CentOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4366
@martin-frbg So yes, configure failure was due to extra spaces.
UPD. And the second commit fixes linking.