Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening of header links in new tab functionality added #26

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

subinsk
Copy link
Contributor

@subinsk subinsk commented Dec 10, 2022

Purpose ✨

Reference to issue #15 :
To add page redirection to a new tab when a link of the header is clicked.

Details πŸ“

In this PR, the functionality to open links in a new tab of the header links is added. For that following changes have been made:

  • Added target = {"_blank"} in <a> tag of the links

Dependencies πŸ”—

None

Future Improvements πŸ”­

None

Mentions πŸ‘€

@AnshumanDhiman @Ananyaiitbhilai

Screenshots of relevant screens πŸ“Έ

None

Developer's checklist πŸ“ƒ

  • Followed the coding guidelines.
  • Properly commented the code.
  • No print statements in the code.
  • All the functionalities are working properly.
  • Changes made are not breaking any other part of the project.
  • No UI/UX issues are present.
  • Relevant screenshots are added in the PR. - Not needed as no UI/UX changes are there.
  • Followed the PR guidelines

@AnshumanDhiman AnshumanDhiman merged commit 98e6205 into OpenLake:master Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants