Streaming bodies 3 #2754
Streaming bodies 3 #2754
Conversation
| /* | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
Might be a double license here.
There was a problem hiding this comment.
Sorry - I am not following - I think this is the license block in all of the Feign core source files?
https://github.com/trumpetinc/feign.git into streaming-bodies-3
|
I have made the requested changes. I want to make sure we are on the same page about the state of this PR before you accept it. Right now:
Sometime in the next couple of days, I will review the following Client implementations and share my thoughts - I'm a little worried that some of these Client implementations assume that requests will be provided as InputStreams, which is not compatible with the new approach I am proposing (converting an outputstream to an inputstream requires a separate worker thread). I'm confident that I can make this work with JAX-RS and Apache. So there may be some philosophical discussion required here. |
|
May I try pr for OkHttpClient? |
I am still evaluating all of the various Client implementations to make sure that the current approach (requests using OutputStream) will work. So I have not updated OkHttpClient for the new functionality (and probably won't until I finish the evaluation to make sure the approach I've implemented will work). That said, I just checked, and it should be straightforward to adjust OkHttpClient to support streaming. For streaming requests, we would need to create our own implementation of RequestBody and override writeTo() that would call OutputStreamSender.sendToOutputStream(sink.outputStream()). Without this change, OkHttpClient will effectively have the original behavior of loading the entire request into memory before sending it. Streaming responses are easier to implement - it actually should work with the existing code. I still want to make one change to OkHttpClient.toBody() to have it properly apply the header charset in the asReader() method, but that's a small thing. |
Improving request and response handling to use streams instead of in-memory byte arrays. Streams are retriable (up to some amount of reading).
To demonstrate this streaming functionality, I have added decoders for handling typical stream-oriented body types (see /core/src/main/java/feign/stream/InputStreamAndReaderDecoder.java) - I suspect that eventually these encoders/decoders will be broken out of the core library.
Current state of the branch: Response streaming has been implemented.
Next: Add support for request streaming.