Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 7.3.0 #48

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Bump version to 7.3.0 #48

merged 1 commit into from
Feb 19, 2024

Conversation

mikkka
Copy link
Contributor

@mikkka mikkka commented Feb 15, 2024

Bump open api generator version to 7.3.0

@wing328 please have a look

.java-version Outdated
@@ -1 +1 @@
1.8
17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be 11 as that's the mininal JDK version supported at the moment.

Copy link
Contributor Author

@mikkka mikkka Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed to 11

@wing328
Copy link
Member

wing328 commented Feb 15, 2024

The CI tests failed. Please take a look when you've time.

@@ -45,7 +45,7 @@ object OpenApiGeneratorPlugin extends sbt.AutoPlugin
val OpenApiCodegen = config("openApiCodegen")

override def globalSettings: Seq[Def.Setting[_]] = Seq(
aggregate in openApiGenerators := false
openApiGenerators / aggregate := false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please elaborate on this change?

looks like this caused the CI tests to fail: https://github.com/OpenAPITools/sbt-openapi-generator/actions/runs/7920353292/job/21636830291?pr=48

@wing328
Copy link
Member

wing328 commented Feb 16, 2024

@mikkka
Copy link
Contributor Author

mikkka commented Feb 19, 2024

@wing328 wing328 merged commit 4ae9bf0 into OpenAPITools:master Feb 19, 2024
1 check passed
@mikkka
Copy link
Contributor Author

mikkka commented Feb 20, 2024

Hi @wing328 , do you think that it's time for a new release?

@mikkka
Copy link
Contributor Author

mikkka commented Feb 22, 2024

Hi @wing328 , would you kindly release new version?

@wing328
Copy link
Member

wing328 commented Feb 22, 2024

@wing328
Copy link
Member

wing328 commented Feb 22, 2024

the publish failed since bintray has been unset: https://github.com/OpenAPITools/sbt-openapi-generator/actions/runs/7961025131/job/21731316245

i'll try to see if i can manually publish it this weekend

@wing328
Copy link
Member

wing328 commented Feb 25, 2024

fyi. filed #49 to switch to sonatype for publishing

@mikkka
Copy link
Contributor Author

mikkka commented Feb 26, 2024

@mikkka does the staging looks good to you?

https://oss.sonatype.org/service/local/repositories/orgopenapitools-1346/content/org/openapitools/sbt-openapi-generator_2.12_1.0/7.3.0+0-4ae9bf0a+20240226-0016/sbt-openapi-generator-7.3.0+0-4ae9bf0a+20240226-0016.jar

Jar looks good. Wait for it being placed in nexus, so it can be included in project via addSbtPlugin("org.openapitools" % "sbt-openapi-generator" % "7.3.0")

@wing328
Copy link
Member

wing328 commented Feb 26, 2024

just did a released of 7.3.0. can you please give it a try?

@mikkka
Copy link
Contributor Author

mikkka commented Feb 26, 2024

@wing328
Copy link
Member

wing328 commented Feb 26, 2024

thanks for checking. i'll take another look tomorrow

@wing328
Copy link
Member

wing328 commented Mar 26, 2024

just published to https://repo1.maven.org/maven2/org/openapitools/sbt-openapi-generator_2.12_1.0/7.3.0/ by skipping the version plugin

can you please give it another try?

if it works, i'll cut another release for openapi generator v7.4.0

@mikkka
Copy link
Contributor Author

mikkka commented Mar 26, 2024 via email

@wing328
Copy link
Member

wing328 commented Mar 26, 2024

good.

can you please give it a try to see if the sbt plugin works for you as expected?

@mikkka
Copy link
Contributor Author

mikkka commented Mar 28, 2024 via email

@wing328
Copy link
Member

wing328 commented Mar 29, 2024

thanks for testing it

just published v7.4.0: https://central.sonatype.com/artifact/org.openapitools/sbt-openapi-generator/7.4.0

@pan3793
Copy link

pan3793 commented Jul 10, 2024

why drop support Java 8

@wing328
Copy link
Member

wing328 commented Jul 10, 2024

it's reached EOL a while ago.

if you can't use JDK11+ in your environment, please use docker instead, e.g. https://hub.docker.com/r/openapitools/openapi-generator-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants