-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 7.3.0 #48
Conversation
.java-version
Outdated
@@ -1 +1 @@ | |||
1.8 | |||
17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be 11 as that's the mininal JDK version supported at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed to 11
The CI tests failed. Please take a look when you've time. |
@@ -45,7 +45,7 @@ object OpenApiGeneratorPlugin extends sbt.AutoPlugin | |||
val OpenApiCodegen = config("openApiCodegen") | |||
|
|||
override def globalSettings: Seq[Def.Setting[_]] = Seq( | |||
aggregate in openApiGenerators := false | |||
openApiGenerators / aggregate := false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please elaborate on this change?
looks like this caused the CI tests to fail: https://github.com/OpenAPITools/sbt-openapi-generator/actions/runs/7920353292/job/21636830291?pr=48
can you please update https://github.com/OpenAPITools/sbt-openapi-generator/actions/runs/7927084946/workflow?pr=48#L29 to jdk11 as well? |
done |
Hi @wing328 , do you think that it's time for a new release? |
Hi @wing328 , would you kindly release new version? |
the publish failed since bintray has been unset: https://github.com/OpenAPITools/sbt-openapi-generator/actions/runs/7961025131/job/21731316245 i'll try to see if i can manually publish it this weekend |
fyi. filed #49 to switch to sonatype for publishing |
Jar looks good. Wait for it being placed in nexus, so it can be included in project via |
just did a released of 7.3.0. can you please give it a try? |
Found this: https://oss.sonatype.org/content/repositories/snapshots/org/openapitools/sbt-openapi-generator_2.12_1.0/7.3.0+0-4ae9bf0a+20240226-0000/ I think version is broken and there are no |
thanks for checking. i'll take another look tomorrow |
just published to https://repo1.maven.org/maven2/org/openapitools/sbt-openapi-generator_2.12_1.0/7.3.0/ by skipping the version plugin can you please give it another try? if it works, i'll cut another release for openapi generator v7.4.0 |
Ok, now it can be seen.
вт, 26 мар. 2024 г. в 08:39, William Cheng ***@***.***>:
… just published to
https://repo1.maven.org/maven2/org/openapitools/sbt-openapi-generator_2.12_1.0/7.3.0/
by skipping the version plugin
can you please give it another try?
if it works, i'll cut another release for openapi generator v7.4.0
—
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABEFWKJEC2BYYMGEVUMOFDY2DUWZAVCNFSM6AAAAABDKIKIIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJZGMZDKMBTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
good. can you please give it a try to see if the sbt plugin works for you as expected? |
Hi,
Seems to work fine.
вт, 26 мар. 2024 г. в 18:41, William Cheng ***@***.***>:
… good.
can you please give it a try to see if the sbt plugin works for you as
expected?
—
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABEFWPUKVOHU6TN4SOMXALY2F3HJAVCNFSM6AAAAABDKIKIIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRQGQ3DCMJRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
thanks for testing it just published v7.4.0: https://central.sonatype.com/artifact/org.openapitools/sbt-openapi-generator/7.4.0 |
why drop support Java 8 |
it's reached EOL a while ago. if you can't use JDK11+ in your environment, please use docker instead, e.g. https://hub.docker.com/r/openapitools/openapi-generator-cli |
Bump open api generator version to 7.3.0
@wing328 please have a look