Artifacts Store (without Metadata) #185
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… length to request header
dlamoris
reviewed
Jan 7, 2025
| inspect() | ||
| } | ||
|
|
||
| processAndSubmitUserQuery(requestContext, prefixes["mor-artifact"]!!, ARTIFACT_QUERY_CONDITIONS.append { |
There was a problem hiding this comment.
processAndSubmitUserQuery function will need to support prefixes["mor-artifact"], suggest fix after merging
|
…EE/flexo-mms-layer1-service into feat/artifact-store-metadataless-tests Pull in auth fixes for StoreRead.kt
…ss-tests Feat/artifact store metadataless tests
dlamoris
reviewed
Feb 13, 2025
| @@ -23,6 +23,60 @@ suspend fun GspLayer1Context<GspReadResponse>.readModel(refType: RefType) { | |||
| } | |||
| } | |||
|
|
|||
| val authorizedIri = "<${MMS_URNS.SUBJECT.auth}:${transactionId}>" | |||
There was a problem hiding this comment.
The added things here are from a borked merge from develop, can just take them out
dlamoris
reviewed
Feb 13, 2025
| */ | ||
| fun Route.storeArtifacts() { | ||
| // all artifacts | ||
| storageAbstractionResource("$ARTIFACTS_PATH/store") { |
There was a problem hiding this comment.
discussion on getting metadata vs store:
remove /store
add query param for download for get, default is to enumerate with content-type turtle with content negotiation in future
There was a problem hiding this comment.
would extend to get in single artifact
dlamoris
reviewed
Feb 20, 2025
|
|
||
| // state of an artifact | ||
| head { | ||
| // headArtifact() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #175 .
This PR implements the following two endpoints for storing and retrieving arbitrary resources under a given repo:
/orgs/{orgId}/repos/{repoId}/artifacts/store/orgs/{orgId}/repos/{repoId}/artifacts/store/{artifactId}This change also introduces a new set of object-centric permissions for CRUD'ing Artifacts. Therefore, the
m-graph:AccessControl.Definitionsgraph needs to be updated with the new permissions, and them-graph:Schemagraph should also be updated with the new triples (though this graph currently has no effect on functionality).TODO: