[18.0][ADD] calendar_public_holiday

[xaviedoanhduy]

context:

• from this comment [16.0] hr_holidays_public: Deprecate use of employee_id in favour of partner_id hr-holidays#110 (comment), extract some features from hr_holidays_public module into new module so that it can be used in other contexts and no longer depends on HR.

note:

• rename the hr.holidays.public model and related models to calendar.public.holiday to match the Calendar repo.
• fix words like Holidays Public to Public holidays (because it is misspelled)
• moving tests and modifications from the old module will only concern the scope of functions in this module.

[victoralmau]

Code and functional review.

IMO the copyright of the corresponding files must be maintained to respect the attribution of all because this module is a “split” of the already existing hr_holidays_public module.

[xaviedoanhduy]

Code and functional review.

IMO the copyright of the corresponding files must be maintained to respect the attribution of all because this module is a “split” of the already existing hr_holidays_public module.

thanks for your suggestion, I have updated the copyright.

[victoralmau]

Ping @chienandalu

[pedrobaeza]

Isn't the migration scripts missing here?

[chienandalu]

Isn't the migration scripts missing here?

I'd say that the hr_holidays_public stuff relative to time-off is goint to be still needed so the migration work could be done there, isn't it?

[pedrobaeza]

I think it should be done here, as the public holidays should be transferred here.

[victoralmau]

Ping @pedrobaeza can you review it?

[pedrobaeza]

Thanks for the efforts. Apart from the inside comments, other points:

• A plain user shouldn't be able to create nor modify public holidays as it's happening right now (try with demo user in runboat).
• I think the menus should be inside Calendar > Configuration.

[xaviedoanhduy]

A plain user shouldn't be able to create nor modify public holidays as it's happening right now (try with demo user in runboat).

Hi @pedrobaeza, since this module no longer depends on hr_holidays but instead on the calendar module, so I changed the access of the models to be the same as in the dependent module (calendar) with the permission groups, see: https://github.com/odoo/odoo/blob/4209d441afa058a87e142b44d6e33a546741dd2b/addons/calendar/security/ir.model.access.csv?plain=1#L7-L8

[pedrobaeza]

Yes, but they shouldn't follow the same rules, as public holidays are defined by managers, not by plain users. When adding hr_holidays_public, you can extend the permissions to allow HR managers to set them, but on this base module, only settings users should be able to modify this important information.

[xaviedoanhduy]

Yes, but they shouldn't follow the same rules, as public holidays are defined by managers, not by plain users. When adding hr_holidays_public, you can extend the permissions to allow HR managers to set them, but on this base module, only settings users should be able to modify this important information.

Ok, thanks for your advice and clarification. I have updated the permission group on the models of this module.

[pedrobaeza]

Don't remove the super-menu "Public Holidays". Just host it inside the "Configuration" one. Please keep also the empty lines out.

[pedrobaeza]

Thank you!

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-142-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at a958c9b. Thanks a lot for contributing to OCA. ❤️