-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit/check-merge-conflicts-2: fix use outside dev shell #12373
Conversation
@mergify queue |
🛑 The pull request has been removed from the queue
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
@mergify rebase |
❌ Base branch update has failedGit reported the following error:
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
This should probably be rebased to resolve the test failures. |
Note that this is just a script that is meant to run outside a derivation (but also can be called by a derivation builder). `touch $out` does not belong in it. `touch $out` worked accidentally in the derivation-based check, and also in the dev shell, but if pre-commit is invoked without the dev shell it would fail.
This seems to be the way to do it now, even though I can't run them without setting at least one env var. I'll only fix shellcheck for now. Don't shoot the messenger. It isn't quite clear to me why the previous commit masked this problem, but I'm glad shellcheck has an effect or more effect now.
11962d3
to
65f57c4
Compare
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
This way shellcheck is ok with it, and it conveys that a significant chunk of the test is skipped.
65f57c4
to
414c346
Compare
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at aa383a0 |
Note that this is just a script that is meant to run outside a derivation (but also can be called by a derivation builder).
touch $out
does not belong in it.touch $out
worked accidentally in the derivation-based check, and also in the dev shell, but if pre-commit is invoked without the dev shell it would fail.Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.