Update build-extensions-win.json #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeteBishwhip
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Hi and thank you for your contribution.
Unfortunately, this PR can't be accepted as the build-meta/build-extensions-win.json file is automatically generated by our build.
Typically, the php-extensions.txt file in the root directory will determine which extensions are built into the NativePHP binaries. This is to ensure consistency across all binaries generated for all architectures.
If you wanted xmlwriter included, it would need to be in that file and would require some justification.
Can you provide your reasoning for requiring this extension?
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.