-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WPF Airspace - WebView2CompositionControl #4804
Open
champnic
wants to merge
6
commits into
main
Choose a base branch
from
wpf-webview2compositioncontrol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
champnic
changed the title
Create WPF_WebView2CompositionControl
WPF Airspace - WebView2CompositionControl
Sep 16, 2024
david-risney
added
the
review completed
WebView2 API Proposal that's been reviewed and now needs final update and push
label
Oct 23, 2024
Noting the review is completed with no issues to resolve since its not obvious that's the case. @champnic please merge when you're ready. |
@david-risney Can you mark it approved? Need 1 reviewer before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API Proposal Review
WebView2 API Proposal for review.
review completed
WebView2 API Proposal that's been reviewed and now needs final update and push
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec draft review for the WPF WebView2CompositionControl