Add Spec for IsWindowControlsOverlayEnabled.md #4613
Conversation
tochukwuIbeEkeocha
added
the
API Proposal Review
tochukwuIbeEkeocha
force-pushed
the
api-isWindowControlsOverlayEnabled-draft
branch
from
2038eac
to
e886ba5
Compare
tochukwuIbeEkeocha
force-pushed
the
api-isWindowControlsOverlayEnabled-draft
branch
2 times, most recently
from
657def7
to
d395730
Compare
tochukwuIbeEkeocha
force-pushed
the
api-isWindowControlsOverlayEnabled-draft
branch
7 times, most recently
from
3866c89
to
bce67e9
Compare
tochukwuIbeEkeocha
force-pushed
the
api-isWindowControlsOverlayEnabled-draft
branch
from
bce67e9
to
700ec3a
Compare
tochukwuIbeEkeocha
force-pushed
the
api-isWindowControlsOverlayEnabled-draft
branch
from
700ec3a
to
654b176
Compare
|
Is there any ETA on when this update might come to webview2? |
tochukwuIbeEkeocha
force-pushed
the
api-isWindowControlsOverlayEnabled-draft
branch
from
654b176
to
5a4eb5f
Compare
| InitializeComponent(); | ||
| m_AppWindow.TitleBar.ExtendsContentIntoTitleBar = true; | ||
|
|
||
| CoreWebView2WindowControlsOverlaySettings config = _coreWebView2Controller.WindowControlsOverlaySettings; |
There was a problem hiding this comment.
We don't have a way to get from a WebView2 class to the controller. Where does _coreWebView2Controller come from? I would expect we either plan to update WPF / WinForms / WinUI2/3 WebView2 class to add something for WindowControlsOverlay or to say your new API is only supported when directly using the CoreWebView2Controller class (eg not using a WebView2 class)
There was a problem hiding this comment.
@tochukwuIbeEkeocha, can you remind we why we decided to put this object on the Controller and not CoreWebView2? I recall at one point we were thinking about passing in the setting in the ControllerOptions, was that why?
Controller is meant for things the framework needs to host a WebView2, or for things where the framework element already has a defined property (i.e. BackgroundColor). The WindowControlOverlay is content being shown inside the WebView2. If we put it on the CoreWebView2, then it is just available in all the frameworks without us and WinUI having to do work to each WebView2 element.
There was a problem hiding this comment.
Will move it to the the CoreWebview2 Object.
|
|
||
|
|
||
| /// The `Height` property in raw screen pixels, allows you to set the height of the overlay and | ||
| /// title bar area. Defaults to 48px. |
There was a problem hiding this comment.
Is there a min height? What happens if you make the value very small?
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
Co-authored-by: Viktoria Zlatinova <[email protected]>
Co-authored-by: Viktoria Zlatinova <[email protected]>
Co-authored-by: Viktoria Zlatinova <[email protected]>
Co-authored-by: David Risney <[email protected]>
tochukwuIbeEkeocha
force-pushed
the
api-isWindowControlsOverlayEnabled-draft
branch
from
2f02f47
to
b38a178
Compare
What
These new APIs introduce support for a Webview2 Window Controls Overlay. The Window Controls Overlay will allow developers to build apps in webview2 with 100% of the UI controlled by the browser process. Devs will be able to create their apps as borderless & caption-less windows, and have the Webview draw its own window control buttons (minimize,maximize, close, restore).