Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Added UI Events KeyboardEvent #301

Open
wants to merge 1 commit into
base: production
Choose a base branch
from

Conversation

phistuck
Copy link
Contributor

@phistuck phistuck commented Oct 1, 2015

For code and an updated key attributes.

Review on Reviewable

For code and an updated key attributes.
@travisleithead
Copy link
Contributor

I think, rather than add a new entry, we just need to reset (and generalize a bit) the exist entry named "DOM3 Keyboard Events". Can you reformulate your change to update this existing entry?

Specifically, updating the name from DOM3 to UI Events, and adding your prose about .key and .code, as well as changing the state back to Under Consideration.

@phistuck
Copy link
Contributor Author

The chromestatus.com ID is problematic... Can you add support for multiple IDs (how would that even look?)?
chromestatus.com has one ID for KeyboardEvent.code and one ID for KeyboardEvent.key, as they are shipped separately.

For my reference, this update keeps the same (ambiguous) ID -

  {
    "name": "UI Events Keyboard Events",
    "category": "User input",
    "link": "https://w3c.github.io/uievents/#interface-KeyboardEvent",
    "summary": "KeyboardEvent: keydown, keyup, keypress, as well as KeyboardEvent.code and an up to date KeyboardEvent.key.",
    "standardStatus": "Working draft or equivalent",
    "ieStatus": {
      "text": "Under Consideration",
      "iePrefixed": "",
      "ieUnprefixed": ""
    },
    "msdn": "",
    "wpd": "",
    "demo": "",
    "id": 4748790720364544
  },

@travisleithead
Copy link
Contributor

Works for me, but maybe @jacobrossi has strong feelings?

@jacobrossi
Copy link
Contributor

@phistuck sorry this got stale. Both of these specs are shipped in Chrome. So I think we can just link to one of their IDs and it'll be ok. I don't think we'll have too many instances of many:1 relationships between the sites, so it's not really worth designing it to support that.

If that's good with you, can you just update this to resolve merge conflicts?

@phistuck
Copy link
Contributor Author

Both of these specs are shipped in Chrome.

Only code is shipped. Or did you mean the actual specifications (also not completely shipped, I think)?

@jacobrossi
Copy link
Contributor

Hmm. Alternatively, we could just list Chrome as "In Development" since the feature is only partially supported? I really don't like splitting it into two entries since they're so tightly related and we want to keep the granularity mostly coarse on Status.

Copy link

@JulienVink JulienVink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @phistuck)

a discussion (no related file):
Long day short nights will do.


Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants