Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation note of MI access mode in csi-secrets-store-identity-access.md #121971

Closed
wants to merge 2 commits into from

Conversation

JoeyC-Dev
Copy link
Contributor

@JoeyC-Dev JoeyC-Dev commented Apr 25, 2024

Proposed change:

  1. Add deprecation note to alert user that both managed identity access modes will be deprecated.
  2. Change "user identity" to "user-assigned managed identity".

Supporting point:

Copy link
Contributor

@JoeyC-Dev : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented Apr 25, 2024

@Nickomang

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Apr 25, 2024
Copy link
Contributor

Learn Build status updates of commit 32c1eec:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/csi-secrets-store-identity-access.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@PMEds28
Copy link
Contributor

PMEds28 commented Jul 8, 2024

@Nickomang

Can you review this old PR and determine whether it needs to be closed or merged?

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. If the changes no longer apply, add an explanation and a #please-close comment to close the PR.

@MicrosoftDocs/public-repo-pr-review-team

@JillGrant615
Copy link
Contributor

@JoeyC-Dev @Nickomang

Can you review this old PR and determine whether it needs to be closed or merged?

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. If the changes no longer apply, add an explanation and a #please-close comment to close the PR.

@MicrosoftDocs/public-repo-pr-review-team

@Nickomang
Copy link
Contributor

Thanks for the feedback, @JoeyC-Dev! At this time, we're in the process of migrating this content to a new repository. I'll be closing this pull request for now, but I will follow up over the next few weeks with details on how you can re-open the changes against the new repo. We appreciate the patience as we finalize the migration.

#please-close

@Nickomang
Copy link
Contributor

@JoeyC-Dev, We’re happy to share that contributions to AKS are once again possible at MicrosoftDocs/azure-aks-docs. We appreciated your patience during this migration.

To re-open your contribution, follow these steps:

  1. Fork and clone the new repository MicrosoftDocs/azure-aks-docs.
  2. Create a new branch in your fork.
  3. Copy the raw markdown for each file touched in your original PR.
  4. In your fork’s new branch, paste each markdown file.
  5. Commit the changes and open a new PR against the MicrosoftDocs/azure-aks-docs main branch.

@JoeyC-Dev JoeyC-Dev deleted the patch-5 branch August 2, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants