Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only declare exception when thrown #82

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Mar 6, 2024

Description

When an eckit exception is declared it writes to standard out. This change moves the declaration so that it only happens when the exception is thrown, reducing spurious output in the log files.

Testing

@twsearle twsearle requested review from s-good and odlomax March 6, 2024 17:18
@twsearle twsearle self-assigned this Mar 6, 2024
Copy link
Collaborator

@s-good s-good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks.

@twsearle twsearle merged commit 4027791 into develop Mar 8, 2024
2 checks passed
@twsearle twsearle deleted the bugfix/remove-spurious-badparameter-messages branch March 8, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants