MPI norm calculation for multiple processes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsearle
force-pushed
the
feature/mpi-norm-calculation
branch
from
72329be
to
237a02a
Compare
twsearle
force-pushed
the
feature/mpi-norm-calculation
branch
from
237a02a
to
22b2d6f
Compare
Until atlas-orca updates beyond the current version, any test with halo > 1 ought to fail during the meshgeneration.
DJDavies2
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When orca-jedi runs on a checkerboard partitioned grid, the calculation of the norm is incorrect. This is because the total has not been collected accross the various processors. This change fixes this issue so that the total norm of the field is present on every process.
Issue(s) addressed
Part of #53
Dependencies
The following must be merged before ctests will pass:
Checklist