Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to work with changes to UFO filters #121

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Update to work with changes to UFO filters #121

merged 3 commits into from
Oct 22, 2024

Conversation

ctgh
Copy link
Contributor

@ctgh ctgh commented Oct 4, 2024 •
edited
Loading

Description

Updates to account for moving the filter factory from oops to ufo.

Issue(s) addressed

N/A

Dependencies

build-group=https://github.com/JCSDA-internal/oops/pull/2760
build-group=https://github.com/JCSDA-internal/ufo/pull/3475
build-group=MetOffice/opsinputs#225
build-group=MetOffice/nemo-feedback#72

Impact

N/A

Checklist

  • I have updated the unit tests to cover the change
  • New functions are documented briefly via Doxygen comments in the code
  • I have linted my code using cpplint
  • I have run the unit tests
  • I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments

@ctgh ctgh requested a review from twsearle as a code owner October 4, 2024 05:37
@ctgh ctgh mentioned this pull request Oct 4, 2024
Merged
5 tasks
@ctgh ctgh requested a review from mikecooke77 October 4, 2024 05:38
mikecooke77
mikecooke77 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@mikecooke77 mikecooke77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me. Could you add the build group to the ufo and oops prs. So that our CI passes.

@ctgh
Copy link
Contributor Author

ctgh commented Oct 4, 2024

@mikecooke77 Thanks, now done.

@matthewrmshin matthewrmshin mentioned this pull request Oct 4, 2024
Merged
twsearle
twsearle approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@twsearle twsearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for adding this!

mikecooke77
mikecooke77 requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@mikecooke77 mikecooke77 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ci is failing because you need the same change in:
src/mains/orcamodel3DVar.cc
I'll push a fix.

mikecooke77
mikecooke77 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@mikecooke77 mikecooke77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed fix. Hope thats OK.

@ctgh
Copy link
Contributor Author

ctgh commented Oct 17, 2024

@mikecooke77 Thanks for spotting and fixing that.

@twsearle twsearle merged commit b260f3c into develop Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecooke77 mikecooke77 mikecooke77 approved these changes

@twsearle twsearle twsearle approved these changes

Assignees

@ctgh ctgh

Labels
coordinate merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctgh @twsearle @mikecooke77