Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to latest atlas-orca version #118

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Oct 1, 2024

Description

Upgrade the atlas-orca version in the CI container to v0.4.0. This new atlas-orca version supports MPI distributed model data with halos > 1.

We expect some slight differences when calculating norms over the fields. This is because some redundant mesh nodes have been pruned so that the mesh generator will work properly.

Issue(s) addressed

Part of MetOffice/mo-bundle/issues/548

Dependencies

Coordinate with:

  • MetOffice/mo-bundle/pull/555

Impact

Enables MPI distributed configurations of JOPA. For example the eorca12 configuration in sith should give consistent comparisons

Checklist

  • I have updated the unit tests to cover the change
  • I have linted my code using cpplint
  • I have run the unit tests
  • I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments

@twsearle twsearle self-assigned this Oct 1, 2024
@twsearle twsearle force-pushed the upgrade-atlas-orca-0.4.0 branch 3 times, most recently from 9192fd0 to 1ef3797 Compare October 1, 2024 10:23
@twsearle twsearle marked this pull request as ready for review October 1, 2024 14:55
Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my environment. Works as expected.

@twsearle twsearle force-pushed the upgrade-atlas-orca-0.4.0 branch 2 times, most recently from 4c127a3 to 7b48f97 Compare October 10, 2024 13:55
@matthewrmshin matthewrmshin merged commit 343dd1b into develop Oct 22, 2024
2 checks passed
@matthewrmshin matthewrmshin deleted the upgrade-atlas-orca-0.4.0 branch October 22, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants