Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/communication: retry on all connection errors #31555

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Feb 19, 2025

When a connection attempt between two processes fails, they should always retry instead of sometimes retrying and sometimes returning an error (and subsequently crashing).

Motivation

  • This PR fixes a previously unreported bug.

Tips for reviewer

The first commit doesn't change anything functional, just makes logging consistent. The second commit has the meat.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

This commit makes the logging in communication.rs consistent, by adding
`my_index` and `my_epoch` (where available) to each log line.
When a connection attempt between two processes fails, they should
always retry instead of sometimes retrying and sometimes crashing.
@teskje teskje force-pushed the fix-communication-error-handling branch from 7b9720a to c72a49e Compare February 19, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant