Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue to fill out supplementary sections for client side capabilities #206

Merged
merged 2 commits into from
May 12, 2020

Conversation

nchan0154
Copy link
Contributor

No description provided.

@nchan0154 nchan0154 requested a review from AmeliaBR March 29, 2020 04:59
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Member

@AmeliaBR AmeliaBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, Nic.

I've seconded @Malvoz's suggestions, and added a few of my own.

A couple of my suggestions would require some more research, though, so I've also included suggested “ToDo” text so that we can merge now without forgetting to fix it up later.

index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
<li>
<a data-ucr-role="tag" href="#privacy-personal-data"></a>
It is unlikely that this capability could be supported in a fully client-side way,
the inputted address may be revealed to the browser or website author.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs re-writing to be more clear. (But I'm OK merging it as is, and I'll give it a go on a future editing pass.)

Some clean-up & ToDo notes for further details to be added later.
@AmeliaBR
Copy link
Member

Well, that was actually really easy to go through and take all of my own suggestions into a commit, right from the web UI. Hooray for usability improvements on GitHub. Should have done it a month ago!

Thanks again @nchan0154, do let me know when you have time to do any further work on this project.

@AmeliaBR AmeliaBR merged commit 37846d2 into Maps4HTML:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants