-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocFix: Added the documentation for run() method for HydrogenBondAnalysis() #4917
Conversation
…in hbond_analysis.py
modified: AUTHORS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS
as part of this PR.
I have done this per our discussion earlier today @orbeckst |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4917 +/- ##
===========================================
- Coverage 93.66% 93.64% -0.03%
===========================================
Files 177 189 +12
Lines 21850 22916 +1066
Branches 3079 3079
===========================================
+ Hits 20466 21459 +993
- Misses 933 1006 +73
Partials 451 451 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add your GitHub handle to the CHANGELOG. Otherwise looks good to me, thank you!
I just added my handle! Thank you! |
Changes made in this Pull Request:
:inherited-members:
run attribute toHydrogenBondAnalysis
()'s autoclass, so thatBaseAnalysis.run()
is visible forHydrogenBondAnalysis()
in the MDAnalysis Documentation.Developers Certificate of Origin
📚 Documentation preview 📚: https://mdanalysis--4917.org.readthedocs.build/en/4917/