Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix custom exceptions #425

Merged
merged 4 commits into from
Feb 11, 2025
Merged

fix custom exceptions #425

merged 4 commits into from
Feb 11, 2025

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Feb 10, 2025

What does this PR do?

Fixes the case when a custom exception has multiple args and can't be sent via multiprocessing queue.

fixes #424

Before

Hangs indefinitely

image

After

image
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (38d7169) to head (c8cdb52).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #425   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        31     31           
  Lines      2023   2025    +2     
===================================
+ Hits       1808   1811    +3     
+ Misses      215    214    -1     

@aniketmaurya aniketmaurya enabled auto-merge (squash) February 11, 2025 10:46
@aniketmaurya aniketmaurya merged commit ccc322a into main Feb 11, 2025
20 of 21 checks passed
@aniketmaurya aniketmaurya deleted the aniket/fix-custom-exception branch February 11, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiprocessing.managers.RemoteError
5 participants