Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't start zmq when fast_queue=false #417

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jan 16, 2025

What does this PR do?

Broker doesn't need to be running when user sets fast_queue=False which means we won't use zmq as queue.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya merged commit 1c85a47 into main Jan 16, 2025
19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/zmq-no-start branch January 16, 2025 17:26
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (515f28b) to head (457dedb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #417   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        31     31           
  Lines      2020   2021    +1     
===================================
+ Hits       1807   1808    +1     
  Misses      213    213           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants