Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable multiple workers for ZMQ #411

Merged
merged 14 commits into from
Jan 13, 2025
Merged

enable multiple workers for ZMQ #411

merged 14 commits into from
Jan 13, 2025

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jan 13, 2025

What does this PR do?

This PR, enables fast queue using ZMQ for multiple inference workers and encapsulates the socket connection and zmq details for better code readability.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya changed the title enable multiple workers for ZMQ [wip] enable multiple workers for ZMQ Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 84.70588% with 26 lines in your changes missing coverage. Please review.

Project coverage is 89%. Comparing base (d1fefd7) to head (06e2cf3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #411   +/-   ##
===================================
+ Coverage    88%    89%   +2%     
===================================
  Files        30     31    +1     
  Lines      1987   2017   +30     
===================================
+ Hits       1740   1804   +64     
+ Misses      247    213   -34     

@aniketmaurya aniketmaurya changed the title [wip] enable multiple workers for ZMQ enable multiple workers for ZMQ Jan 13, 2025
@aniketmaurya aniketmaurya requested a review from tchaton as a code owner January 13, 2025 18:23
@aniketmaurya aniketmaurya enabled auto-merge (squash) January 13, 2025 18:23
@aniketmaurya aniketmaurya merged commit 5aef366 into main Jan 13, 2025
21 checks passed
@aniketmaurya aniketmaurya deleted the aniket/zmq-multi-worker branch January 13, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants