Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix callback runner to execute after predict #406

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jan 9, 2025

What does this PR do?

Fixes the bug where on_after_predict hook for callbacks are not executed with batched inference.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (747308a) to head (3df3be0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #406   +/-   ##
===================================
- Coverage    89%    89%   -0%     
===================================
  Files        30     30           
  Lines      1893   1893           
===================================
- Hits       1683   1681    -2     
- Misses      210    212    +2     

@aniketmaurya aniketmaurya enabled auto-merge (squash) January 10, 2025 12:37
@aniketmaurya aniketmaurya merged commit 501639b into main Jan 10, 2025
21 checks passed
@aniketmaurya aniketmaurya deleted the fix-batching-callback branch January 10, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants