Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support for response_format field in OpenAI Spec #197

Merged

Conversation

bhimrazy
Copy link
Contributor

@bhimrazy bhimrazy commented Aug 7, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #196 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy marked this pull request as draft August 7, 2024 19:22
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 80%. Comparing base (f73d30d) to head (3bb25b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #197   +/-   ##
===================================
  Coverage    80%    80%           
===================================
  Files        13     13           
  Lines      1041   1058   +17     
===================================
+ Hits        835    851   +16     
- Misses      206    207    +1     

@bhimrazy bhimrazy changed the title [WIP] Feat: Add support for response_format field in OpenAI Spec Feat: Add support for response_format field in OpenAI Spec Aug 8, 2024
@bhimrazy bhimrazy marked this pull request as ready for review August 8, 2024 20:18
Copy link
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far @bhimrazy 🚀 !! Let's check the Pydantic alias to avoid shadowing the BaseModel attribute.

@aniketmaurya aniketmaurya merged commit 8ff924a into Lightning-AI:main Aug 14, 2024
19 of 20 checks passed
@bhimrazy bhimrazy deleted the feat/add-response-format-support branch August 15, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for response_format in OpenAI Spec
2 participants