-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add support for response_format field in OpenAI Spec #197
Feat: Add support for response_format field in OpenAI Spec #197
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
===================================
Coverage 80% 80%
===================================
Files 13 13
Lines 1041 1058 +17
===================================
+ Hits 835 851 +16
- Misses 206 207 +1 |
…y/LitServe into feat/add-response-format-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far @bhimrazy 🚀 !! Let's check the Pydantic alias to avoid shadowing the BaseModel attribute.
for more information, see https://pre-commit.ci
Before submitting
What does this PR do?
Fixes #196 .
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃