-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamlit/UI #81
Streamlit/UI #81
Conversation
Reviewer's Guide by SourceryThis pull request implements significant changes to the Streamlit UI for a CMTJ (Coupled Magnetic Tunnel Junction) simulator. The changes focus on improving the user interface, adding new features, and enhancing the overall functionality of the application. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LemurPwned - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Summary by Sourcery
Enhance the Streamlit UI for domain fitting by adding new features for displaying domain magnetization in polar angles and improving the layout and user guidance. Update the rendering functions to support individual domain plots in both Cartesian and polar coordinates. Revise the README to include updated information about the Streamlit app and its capabilities.
New Features:
Enhancements:
Documentation: