bug(NoteManager): Fix default edit access not working on notes #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good call!
In the long run I should fix this so that it can actually not conflict with a username |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NoteEdit.vue, the default edit permission for notes was not being handled, making it effectively non-functional, unless your username was 'default' ;). This change makes the NoteManager check for default edit permission as well as per-user.
I also noticed that the hard-coded string was in a few places in the NoteEdit file, so since I was going to add another instance of it, I decided to make it a constant and reuse it in multiple places instead. Hope that's alright to include in this.