feat(Notes): Add Notes button to player's MenuBar #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kruptein
reviewed
Oct 19, 2024
client/src/game/ui/menu/MenuBar.vue
Outdated
| @@ -93,6 +93,10 @@ const openClientSettings = (): void => uiSystem.showClientSettings(!uiState.raw. | |||
| <div style="width: 12.5rem; overflow-y: auto; overflow-x: hidden"> | |||
| <!-- CHARACTERS --> | |||
| <Characters /> | |||
| <!-- NOTES --> | |||
There was a problem hiding this comment.
I would prefer to keep the location it has in the DM menu (i.e. below assets), as for me as a dm the location of the assets section, both because it's one of the most used ones and people might have some muscle memory where to click, but also because the list can expand down vertically more when it's higher.
I do agree that notes should be visible to players though, so could you end the dm if clause before notes and re-open it afterwards instead?
There was a problem hiding this comment.
Totally makes sense, will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that as a player, you cannot access the NoteManager from the MenuBar like you can as the DM. The player has access to the NoteManager in other ways (eg right click menu of shape), so I feel like it would be nice to have a consistent way to open for them. This would also allow them access if there are only notes without shapes attached.