fix broken dialogs

Kriechi · Oct 6, 2018 · 1b10c40 · 1b10c40
1 parent 2b9f17a
commit 1b10c40
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog of Cura-DuetRRFPlugin
 
+## v0.0.20: 2018-10-06
+  * fix broken dialogs
+
 ## v0.0.19: 2018-10-05
   * fix more Cura 3.5 incompatibilities
 

diff --git a/DuetRRFOutputDevice.py b/DuetRRFOutputDevice.py
@@ -123,10 +123,6 @@ def requestWrite(self, node, fileName=None, *args, **kwargs):
 
         path = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'UploadFilename.qml')
         self._dialog = CuraApplication.getInstance().createQmlComponent(path, {"manager": self})
-        if dialog is None:
-            Logger.log("e", "QQmlComponent status %s", self._component.status())
-            Logger.log("e", "QQmlComponent errorString %s", self._component.errorString())
-            raise RuntimeError(self._component.errorString())
         self._dialog.textChanged.connect(self.onFilenameChanged)
         self._dialog.accepted.connect(self.onFilenameAccepted)
         self._dialog.show()

diff --git a/DuetRRFPlugin.py b/DuetRRFPlugin.py
@@ -49,10 +49,6 @@ def stop(self):
     def _createDialog(self, qml):
         path = os.path.join(os.path.dirname(os.path.abspath(__file__)), qml)
         dialog = CuraApplication.getInstance().createQmlComponent(path, {"manager": self})
-        if dialog is None:
-            Logger.log("e", "QQmlComponent status %s", self._component.status())
-            Logger.log("e", "QQmlComponent errorString %s", self._component.errorString())
-            raise RuntimeError(self._component.errorString())
         return dialog
 
     def _showDialog(self, qml):

diff --git a/plugin.json b/plugin.json
@@ -2,7 +2,7 @@
     "name": "DuetRRF",
     "author": "Thomas Kriechbaumer",
     "description": "Upload and Print to DuetWifi / DuetEthernet / Duet Maestro with RepRapFirmware.",
-    "version": "0.0.19",
+    "version": "0.0.20",
     "minimum_cura_version": "3.5",
     "maximum_cura_version": "3.5",
     "api": 5