Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gradle Project Isolation solution. #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Gradle Project Isolation solution. #285

wants to merge 1 commit into from

Conversation

deep4nsh
Copy link

@deep4nsh deep4nsh commented Jan 7, 2025

No description provided.

fzhinkin
fzhinkin reviewed Jan 7, 2025
View reviewed changes
plugin/main/src/kotlinx/benchmark/gradle/BenchmarkConfiguration.kt
@@ -70,7 +70,7 @@ constructor(
extension: BenchmarksExtension,
name: String
) : BenchmarkTarget(extension, name) {
var jmhVersion: String = (extension.project.findProperty("benchmarks_jmh_version") as? String) ?: "1.21"
var jmhVersion: String = providers.gradleProperty("benchmarks_jmh_version").orNull ?: "1.21"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this code compiles?

@fzhinkin
Copy link
Contributor

fzhinkin commented Jan 7, 2025

Please add a regression test reproducing the original issue, if possible.
You can check tests in the integration module for examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhinkin fzhinkin fzhinkin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deep4nsh @fzhinkin