fix: added fix to validate for top-level type in parameter schemas while using oneOf in request-validator plugin. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 69.08% 68.97% -0.11%
==========================================
Files 24 24
Lines 3290 3343 +53
==========================================
+ Hits 2273 2306 +33
- Misses 848 864 +16
- Partials 169 173 +4 ☔ View full report in Codecov by Sentry. |
Prashansa-K
force-pushed
the
fix/oneof-schemas
branch
from
45ac9b7
to
a9aa487
Compare
Tieske
requested changes
Oct 23, 2024
openapi2kong/oas3_testfiles/17-request-validator-plugin-oneOf-usage.expected.json
Show resolved
Hide resolved
schemas while using oneOf in request-validator plugin. As of now, deck file openapi2kong command was not checking for multiple types used while creating parameter schemas with oneOf, which is not supported by Kong request- validator plugin. Thus, we are forcing for defining a top-level type property and erroring out in case it is not present.
Prashansa-K
force-pushed
the
fix/oneof-schemas
branch
from
bd052a6
to
10162c3
Compare
the uncertainty in maps iteration order in golang
Tieske
reviewed
Nov 5, 2024
Tieske
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, deck file openapi2kong command was not
checking for multiple types used while creating parameter schemas with oneOf, which is not supported by Kong request- validator plugin. Thus, we are forcing for defining a top-level type property and erroring out in case it is not present.
Fixes: #206