Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore Gateway API generation (issue #1427). #1431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

battlebyte
Copy link
Collaborator

@battlebyte battlebyte commented Nov 6, 2024

Fixes #1427
Separate integration tests in kong2kic_integration_test.go and must be explicitly invoked with -tags=integration.
Fix tests to evaluate all yaml objects.

Separate integration tests in kong2kic_integration_test.go and must be explicitly invoked with -tags=integration.
Fix tests to evaluate all yaml objects.
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 71.78423% with 68 lines in your changes missing coverage. Please review.

Project coverage is 29.22%. Comparing base (c88f497) to head (3d71193).

Files with missing lines Patch % Lines
kong2kic/route.go 71.54% 57 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1431      +/-   ##
==========================================
+ Coverage   27.51%   29.22%   +1.70%     
==========================================
  Files          61       61              
  Lines        6272     6511     +239     
==========================================
+ Hits         1726     1903     +177     
- Misses       4423     4474      +51     
- Partials      123      134      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Prashansa-K
Copy link
Contributor

Adding @randmonkey for reviews here as I don't have much context about KIC. Tao will be able to help out in that area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deck file kong2kic default use Ingress API, not Gateway API
3 participants