Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install-debian.sh #6737

Closed
wants to merge 1 commit into from
Closed

Conversation

tekweaver
Copy link

apt packages:
python-dev -> python-dev-is-python3
libusb-1.0 -> libusb-1.0.0

python virtual environment:
python2 -> python3

apt packages:
python-dev -> python-dev-is-python3
libusb-1.0 -> libusb-1.0.0

python virtual environment:
python2 -> python3
@JamesH1978
Copy link
Collaborator

Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks
James

@tekweaver
Copy link
Author

I would like to start by first apologizing. This is the first time I have submitted a pull request and still new to all git has to offer. Python 2 has been EoL since 2020/01/01. I thought to myself "since I HAVE to edit the debian install script every time I download klipper I can contribute a solution to a problem.

The debian install script has not been updated for 2 years.... Python2 went EOL in 2020... FOUR years ago... I was trying to be kind... But fk off trying to get me to sign a legal document for tying to be kind to my fellow human beings.... something to benefit all of us.

THIS RIGHT HERE is a reason to NEVER CONTRIBUTE and just keep an updated fork with my own edits.

@jakep82
Copy link
Collaborator

jakep82 commented Nov 13, 2024

Did you read the document? It effectively just states that you certify you have the right to submit the code.

The only goal is to prevent people from submitting code they didn't write and for which they have no legal copyright.

@tekweaver tekweaver closed this Nov 13, 2024
@Klipper3d Klipper3d deleted a comment from tekweaver Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants