-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update dependencies #6293
ci: update dependencies #6293
Conversation
Signed-off-by: Thijs Triemstra <[email protected]>
Signed-off-by: Thijs Triemstra <[email protected]>
There are a few dependencies that have newer versions but breaking backwards incompatible changes so I didn't update those but I can take a look at those as well if wanted. |
What could go wrong? |
Signed-off-by: Thijs Triemstra <[email protected]>
Alright.
After another review I couldn't find any incompatible changes and all dependencies should now be using their latest version. |
Thanks. We can certainly update the dependencies. I'd like to understand if this is a proactive change or if there is a particular reason to make a change now? -Kevin |
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
@KevinOConnor sorry for the late response.
If you check a random ga build, e.g. https://github.com/Klipper3d/klipper/actions/runs/5828773956, it shows the following warning:
So I try to keep these actions up to date for all my projects. |
Okay, thanks. -Kevin |
Signed-off-by: Thijs Triemstra <[email protected]>
This PR introduced a regression that resulted in actions/stale@v8 closing several PRs. I committed c9aa7ac in an attempt to fix the regression. -Kevin |
i'm sorry @KevinOConnor, that's a pretty shitty regression. i hope it got solved with your additional changes.
|
Signed-off-by: Thijs Triemstra <[email protected]>
Signed-off-by: Thijs Triemstra [email protected]