Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update dependencies #6293

Merged
merged 3 commits into from
Aug 12, 2023
Merged

Conversation

thijstriemstra
Copy link
Contributor

Signed-off-by: Thijs Triemstra [email protected]

Signed-off-by: Thijs Triemstra <[email protected]>
Signed-off-by: Thijs Triemstra <[email protected]>
@thijstriemstra
Copy link
Contributor Author

There are a few dependencies that have newer versions but breaking backwards incompatible changes so I didn't update those but I can take a look at those as well if wanted.

@hcet14
Copy link

hcet14 commented Jul 18, 2023

There are a few dependencies that have newer versions but breaking backwards incompatible changes so I didn't update those but I can take a look at those as well if wanted.

What could go wrong?

Signed-off-by: Thijs Triemstra <[email protected]>
@thijstriemstra
Copy link
Contributor Author

What could go wrong?

Alright.

There are a few dependencies that have newer versions but breaking backwards incompatible changes so I didn't update those

After another review I couldn't find any incompatible changes and all dependencies should now be using their latest version.

@KevinOConnor
Copy link
Collaborator

Thanks. We can certainly update the dependencies. I'd like to understand if this is a proactive change or if there is a particular reason to make a change now?

-Kevin

@github-actions
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@thijstriemstra
Copy link
Contributor Author

@KevinOConnor sorry for the late response.

I'd like to understand if this is a proactive change or if there is a particular reason to make a change now?

If you check a random ga build, e.g. https://github.com/Klipper3d/klipper/actions/runs/5828773956, it shows the following warning:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

So I try to keep these actions up to date for all my projects.

@KevinOConnor KevinOConnor merged commit 594c024 into Klipper3d:master Aug 12, 2023
1 check passed
@KevinOConnor
Copy link
Collaborator

Okay, thanks.

-Kevin

@KevinOConnor
Copy link
Collaborator

This PR introduced a regression that resulted in actions/stale@v8 closing several PRs. I committed c9aa7ac in an attempt to fix the regression.

-Kevin

@thijstriemstra
Copy link
Contributor Author

thijstriemstra commented Aug 21, 2023

i'm sorry @KevinOConnor, that's a pretty shitty regression. i hope it got solved with your additional changes.

What could go wrong?

rogerlz referenced this pull request in DangerKlippers/danger-klipper Dec 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants