Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused common.php functions #2716

Merged

Conversation

williamjallen
Copy link
Collaborator

A bit of spring cleaning to remove functions which have been rendered obsolete since my last pass through common.php.

@williamjallen williamjallen added this to the v3.9 milestone Feb 16, 2025
@williamjallen williamjallen marked this pull request as draft February 16, 2025 04:27
@williamjallen
Copy link
Collaborator Author

Waiting for #2715 to be merged before some of these functions can be removed.

@williamjallen williamjallen force-pushed the delete-unused-common-code branch from 844995f to 0377dd3 Compare February 19, 2025 14:41
@williamjallen williamjallen marked this pull request as ready for review February 19, 2025 15:39
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josephsnyder josephsnyder added this pull request to the merge queue Feb 19, 2025
Merged via the queue into Kitware:master with commit 4d97b62 Feb 19, 2025
7 checks passed
@williamjallen williamjallen deleted the delete-unused-common-code branch February 19, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants