Add Helm chart for CDash #2700
Add Helm chart for CDash #2700
Conversation
Co-authored-by: William Allen <[email protected]>
There was a problem hiding this comment.
It would be good to do some basic testing for this chart eventually. I don't necessarily mind that being left for a future PR. In addition to testing, I think it would be worthwhile to run helm lint to catch basic issues and enforce Helm's preferred style rules.
| # on the CDash webserver instead, you should specify: | ||
| # REMOTE_WORKERS: "true" | ||
| env: |- | ||
| #REMOTE_WORKERS: "true" |
There was a problem hiding this comment.
We talked about it earlier, but I don't think we should support remote workers here. S3 is recommended, and we provide minio support out of the box for anyone who doesn't have an S3 compatible service available. I'm open to other ideas if you feel strongly that we should support remote workers though.
| args: [ "start-website" ] | ||
| env: | ||
| - name: "APP_URL" | ||
| value: "https://{{ .Values.website.url }}" |
There was a problem hiding this comment.
Is the protocol guaranteed to be HTTPS?
| DB_DATABASE: "cdash" | ||
| DB_PORT: "5432" | ||
| DB_HOST: "{{ .Release.Name }}-postgresql" | ||
| DB_CONNECTION: "pgsql" | ||
| DB_LOGIN: "postgres" |
There was a problem hiding this comment.
As we discussed in person a few minutes ago, we should add a check here to conditionally set these values based on whether an external database is being used or not.
| # REMOTE_WORKERS: "true" | ||
| env: |- | ||
| #REMOTE_WORKERS: "true" | ||
| #BACKUP_TIMEFRAME: 36 |
There was a problem hiding this comment.
Is BACKUP_TIMEFRAME useful here?
No description provided.