Fix(CanvasForm): Set empty object value when selecting the expression #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamG640
force-pushed
the
Form_V2_Fix
branch
2 times, most recently
from
daecedf to
3aefb83
Compare
lordrip
reviewed
Feb 20, 2025
| const newValue = { ...value }; | ||
| Object.keys(selectedOneOfSchema.schema.properties).forEach((prop) => { | ||
| delete (newValue as Record<string, unknown>)[prop]; | ||
| const newValue = { ...value }; |
There was a problem hiding this comment.
If the value is anything else than an array or object, it will break
lordrip
reviewed
Feb 20, 2025
Comment on lines
38
to
40
| Object.keys(newProps).forEach((prop) => { | ||
| setValue(newValue, prop, {}); | ||
| }); |
There was a problem hiding this comment.
We're assuming we're gonna always render objects, but there's also the chance the prop is a string
shivamG640
force-pushed
the
Form_V2_Fix
branch
from
3aefb83 to
e454c28
Compare
|
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.